00:16 -!- Umbire has quit [Ping timeout: 260 seconds]
00:17 <Hecubus> [hdf-us] [evil] bouquet (Pri Elf Fem Neu), 470 points, T:1291, killed by a kobold zombie
00:33 <Hecubus> [hdf-us] [evil] bouquet (Sam Gia Fem Law) killed the Goblin King, on T:2823
00:54 <Hecubus> [hdf-us] [evil] bouquet (Sam Gia Fem Law), 5748 points, T:4897, killed by a Mordor orc
01:23 -!- hackemslashem has joined #evilhack
02:18 -!- mobileuser has joined #evilhack
04:16 -!- hackemslashem has quit [Ping timeout: 264 seconds]
05:16 -!- hackemslashem has joined #evilhack
05:19 -!- elenmirie has joined #evilhack
05:58 -!- amateurhour has joined #evilhack
06:37 -!- elenmirie has quit [Quit: Going offline, see ya! (www.adiirc.com)]
07:41 -!- elenmirie has joined #evilhack
07:41 -!- rebatela has quit [Read error: Connection reset by peer]
07:41 -!- rebatela has joined #evilhack
08:05 <mobileuser> YANI remove oilskin cloak from evilhack, an oilskin cloth cloak does the same thing
08:08 <amateurhour> further YANI remove special armours and weapons from variants which have object properties
08:09 <amateurhour> e.g. gauntlets of power should just be a giant's strength oprop etc
08:09 <amateurhour> on ordinary gauntlets
08:26 <K2> that's what grunthack does. i stayed away from that on purpose (the e.g. GoP / giant strength oprop)
08:27 <amateurhour> how come?
08:30 <amateurhour> I like the system in diablo II and lotr rotk gba where all the items (except artifacts) are mundane items with a set of random prefixes and suffixes that modify them
08:30 <amateurhour> I think if amateurhack is ever real I would do something like that
08:33 <K2> its too much. the oprops grunthack has like power/dex/speed/reflection/etc invalidate a ton of other objects. that plus being able to apply them to other magical objects, too over the top
08:34 <Pinkbeast> Also not sure everyone will be enthusiastic about Diabloesque sorting through a thousand bits of junk 
08:34 <amateurhour> as opposed to how it currently is ignoring a thousand bits of junk :^)
08:35 <Pinkbeast> Well, yeah, introduce the DCSSism that an item of mundane appearance is at best uncursed +0 :-)
08:35 <amateurhour> sounds like a good change to me
08:35 <Pinkbeast> I mean, ha ha only serious
08:35 <amateurhour> dcss has a lot of great ideas
08:36 <amateurhour> kinda a hard sell to some nethack players for some reason
08:36 <Pinkbeast> TBF, if people want DCSS they know where to find it; there's no sense in going down entirely the same path
08:37 <amateurhour> true but ideas about making the game more ergonomic and cutting out tedium are great in my book
08:38 <K2> i dont equate a lack of certain oprops as introducting tedium
08:38 <amateurhour> I wasn't suggesting that
08:38 <amateurhour> was replying to Pinkbeast 
08:39 <K2> oh
08:39 <K2> sorry
08:39 <amateurhour> no worries
08:39 <K2> thought it was all part of the same discussion
08:39 * K2 shouldnt try to chat and do work at the same time
08:39 <Pinkbeast> amateurhour: Mmm. And I think _this_ idea is a good one (I would) but I also see why people might be leery of a series of creeping DCSSisms each of which individually looks good.
08:40 <amateurhour> well have no fear because amateurhack will never be real, it's too perfect and perfection can only exist in the ideal
08:41 <amateurhour> is it you that has a dcss variant? are you still working on it?
08:44 <K2> amateurhour, i got another email from the guy that had a hangup with slashem
08:44 <K2> this time its not connection timeout
08:44 <amateurhour> hmmm
08:45 <K2> he's getting it when he reloads a game, at the --more-- prompt
08:45 <amateurhour> is he hanging up at the more prompt?
08:45 <K2> that's what he claims
08:45 <K2> player is 'anon' on hdf-us
08:45 <K2> i just restored his game again, gonna reply to email
08:46 <amateurhour> well hanging up at the more prompt at the very start of the game is dangerzone in all variants I think
08:46 <amateurhour> not sure what vanilla did if anything for that one
08:46 <amateurhour> let's see
08:47 <amateurhour> like save-shred dangerzone
08:53 -!- hackemslashem has quit [Quit: Leaving]
08:54 <amateurhour> looks like vanilla does the print way sooner than slashem and 343
08:54 <amateurhour> so if one hangs up at that point you can't lose the save file
08:54 <K2> hmm
08:55 <amateurhour> gonna go see if 343-nao and 343-hdf changed anything
08:55 <K2> 343-hdf is basically 343-nao with QoL bits
08:55 <Pinkbeast> amateurhour: Yes - https://github.com/damerell/crawl/tree/ihpix
08:55 <amateurhour> yeah fixed in 343-nao
08:56 <amateurhour> nice Pinkbeast, will check it out later
08:56 <amateurhour> K2 I'll take the nao fix and port it to slashem and open a PR later today
08:56 <K2> i tried dcss a looong time ago
08:56 <K2> amateurhour thanks!
08:57 <amateurhour> if you wanted to describe the problem to that user in the meantime you can say that hanging up at that more prompt happens after save deleted but before the game knows what to do with current data when hanging up
08:57 <amateurhour> so it deletes the savefile and then subsequently doesn't save anything from hanging up
08:57 <Pinkbeast> amateurhour: https://crawl.montres.org.uk/about.html discusses where to play and what you get in a bit more detail
09:01 <Pinkbeast> The friendly-ish ghosts are arguably still the best bit
09:03 -!- qt has joined #evilhack
09:05 <amateurhour> anything special if the ghosts are called Casper? :P
09:06 <Pinkbeast> Ha. :-)
09:27 <Hecubus> [hdf-eu] [evil] lacca (Inf Ith Fem Una), 29 points, T:19, killed by a scroll of earth
10:01 <Hecubus> [hdf-eu] [evil] lacca (Inf Ith Fem Una), 280 points, T:503, killed by a shattered potion
10:01 -!- Umbire has joined #evilhack
10:11 <Hecubus> [hdf-eu] [evil] lacca (Inf Ith Fem Una) killed the Goblin King, on T:1344
10:12 <Hecubus> [hdf-eu] [evil] lacca (Inf Ith Fem Una), 2284 points, T:1659, killed by a small mimic
10:19 <Hecubus> [hdf-eu] [evil] lacca (Inf Ith Fem Una), 929 points, T:1060, killed by a kobold
10:43 -!- VaderFLAG_ has joined #evilhack
10:43 -!- VaderFLAG has quit [Killed (lead.libera.chat (Nickname regained by services))]
10:43 -!- VaderFLAG_ is now known as VaderFLAG
10:58 -!- amateurhour has quit [Ping timeout: 265 seconds]
11:01 -!- amateurhour has joined #evilhack
11:06 -!- hackemslashem has joined #evilhack
11:25 <Hecubus> [hdf-eu] [evil] SeamusMcRed (Mon Gia Mal Cha), 725 points, T:723, killed by the Goblin King
12:05 -!- elenmirie has quit [Quit: Going offline, see ya! (www.adiirc.com)]
12:18 -!- elenmirie has joined #evilhack
14:13 <hackemslashem> K2: If I want to add more random appearances for things like rings and wands, can I just add them to the end of their sections in objects.c?  I'm trying to add more like unnethack has but running into a probtype error
14:14 <hackemslashem> I can see scrolls possibly need updating in tilemap.c if you add more, but other things it looks like you can just add them. 
14:15 <K2> the obj limit was removed, so yeah
14:19 <hackemslashem> Hmm, maybe my data entry was bad. 
14:21 <hackemslashem> Ok, I see prob for all rings should be 1
15:00 -!- dbanethacker has joined #evilhack
15:00 <hackemslashem> Yea, mkobj is trying to get the index of the appearance of the ring, not an actual ring... I'm trying to figure out why this is happening only with rings. Because Evil has a few extra wand appearances and no problems with that...
15:01 <hackemslashem> Example: probtype error, oclass=4 i=257  (The last ring is 247, and amulets start at 259)
15:05 <hackemslashem> Actually, the prob of the appearances is automatically 1, so maybe I can't add more appearances because of that...
15:07 <hackemslashem> Who removed the prob field from rings? 
15:08 <aosdict> did you undo the no-longer-needs-to-add-to-1000 thing?
15:08 <amateurhour> I don't think rings have ever had more appearances in vanilla
15:09 <amateurhour> have they?
15:09 <aosdict> anyway if you want a ring with 0 probability, you have to undo the RING definition where it hardcodes prob
15:10 <aosdict> and then probably add a shim in the code that tries to assign 1000 / (# of rings) probability to each ring
15:10 <amateurhour> the no-longer-needs-to-add-to-1000 thing or nlntat1000 as we call it in the biz should be in hackem via evilhack
15:10 <hackemslashem> aosdict: Why would I undo that?
15:10 <amateurhour> didn't see anything that would undo it
15:12 <hackemslashem> Maybe I can just readd the prob field.. 
15:12 <qt> what causes "probtype error" message
15:12 <qt> what is the actual cause of it
15:13 <hackemslashem> mkobj, is trying to create an object - i is the index of the item it wants, but it doesn't point to a valid otyp (the random appearances for rings I added are in a no-man's-land)
15:14 <hackemslashem> My hypothesis is that since all rings have prob=1, the appearances I added are also being figured in
15:14 <qt> yeah i see it, oclass_prob_totals[class] going beyond the actual items of the class basically
15:15 <K2> hackemslashem, i say this without having scrutinized every commit you've made, but you need to be careful. importing slash'em code is bound to cause problems. I learned this the hard way with importing grunthack code (and to an extend, sporkhack code). it may be better to look at what a thing does that you like in slash'em, and do your own implementation
15:15 <qt> yeah you need to make the ones that don't correspond to an actual item 0 probability
15:16 <K2> i'm curious how ma*extent
15:16 <K2> bah
15:16 <K2> i should step away from all writing implements
15:16 <hackemslashem> You say this NOW?? 
15:16 <K2> i'm done with tnnt, so i can focus on other things now :)
15:17 <qt> i think someone has said something like that before
15:17 <qt> actually
15:17 <hackemslashem> I think I've done a fairly decent job unfu**ing slashem code actually
15:17 <amateurhour> I think hackemslashem has already learned that lesson K2 :P
15:17 <Hecubus> [hdf-us] [evil] mightyquinn (Arc Hum Mal Law), 1317 points, T:2149, killed by a rock gnome, while frozen by a monster's gaze
15:17 <hackemslashem> I've also unfuked a bunch of splice too ;D
15:18 <K2> yeah i've seen. i get emails for every issue you do
15:18 <hackemslashem> oh jeez, I'm sorry
15:18 <K2> just saying, be careful. i wonder how many things did work but dont because <slashem thing added>
15:18 <amateurhour> don't be sorry, it's opt-in, K2 loves it
15:19 <K2> sorry for what? i signed up for it
15:19 <amateurhour> he sits by his email client salivating just waiting for the next hit
15:19 <hackemslashem> I gotta stop doing diary entries in the issues...
15:19 <K2> no you dont lol
15:19 <K2> you do you, girlfriend
15:19 <K2> a handful of the issues you've logged stem from evilhack, you're helping me
15:20 <amateurhour> handful
15:20 <amateurhour> big hands
15:20 <amateurhour> :^)
15:20 <hackemslashem> giant hands
15:20 <K2> :(
15:21 <amateurhour> (just joking)
15:21 <qt> liar
15:21 <amateurhour> caught in the act
15:21 <qt> you were seriously accusing K2 of having giant hands
15:22 <hackemslashem> RE above: This is also why I haven't imported techniques
15:22 <amateurhour> it's true
15:22 <hackemslashem> Or #youpoly
15:22 <amateurhour> youpoly is relatively easy to implement
15:22 <amateurhour> techniques would be easier to do yourself than copypaste
15:22 <hackemslashem> Probably, I'm also relatively lazy
15:24 <amateurhour> qt there's a read after free we found in hackem that's also in evilhack and looks like vanilla as well
15:24 <qt> cool what is it?
15:24 <amateurhour> the actual read after free isn't as interesting as the fact it originated in vanilla I suppose
15:24 <amateurhour> it's this basically https://github.com/k21971/EvilHack/issues/107
15:25 <amateurhour> I don't think anyone's reported it to devteam
15:25 <qt> someone should do that
15:26 <amateurhour> yeah
15:26 <qt> wait actually I am confused
15:27 <qt> can water_damage free the object?
15:27 <amateurhour> if it's an acid potion yeah
15:27 <hackemslashem> yea
15:27 <amateurhour> it returns ER_DESTROYED if that happens
15:30 <qt> patch is not enough to fix the use-after-free though
15:30 <qt> s/though/then
15:30 <qt> i think
15:30 <amateurhour> ?
15:30 <qt> it fixes it in that one place but look at the switch/case right under that, if it hits 16-20 that's another one
15:31 <amateurhour> which variant and line number?
15:31 <qt> i'm looking at 3.7
15:31 <qt> fountain.c:443, fountain.c:451
15:32 <amateurhour> oh true
15:32 <qt> it makes me think the er != ER_DESTROYED is a mistake or something, like maybe it ought to be https://termbin.com/lwyc6 instead
15:32 <amateurhour> I didn't even notice that it continues the other day lol
15:33 <amateurhour> nice
15:33 <hackemslashem> good catch
15:33 <qt> but actually that is wrong too
15:33 <qt> lol
15:33 <qt> that's still dereferencing it
15:33 <amateurhour> yeah still reads potentially destroyed 
15:34 <amateurhour> maybe water damage should be the only thing that handles it
15:34 <amateurhour> what's actually the point of this bit?
15:34 <qt> https://termbin.com/m2jb like this maybe
15:34 <qt> tbh I don't know if it actually does anything
15:34 <qt> when I glanced at water_damage it seems like it always destroys the acid but I only looked quickly
15:35 <qt> oh, maybe if it's greased it would have an effect
15:36 <Hecubus> [hdf-us] [evil] mightyquinn (Arc Hum Mal Law), 1179 points, T:2383, killed by a kobold lady
15:36 <qt> lol
15:36 <qt> yeah that's pretty weird
15:36 <hackemslashem> K2: What's cool is there where slashem code has been sketchy, I've usually been able to use something from another fork. Ex Vampires from Un, Firearms from splice
15:36 <qt> it just silently destroys the acid
15:37 <qt> if it's greased
15:37 <amateurhour> you can grease potions?
15:38 <qt> yeah
15:38 <hackemslashem> K2: I finally bit the bullet the other day and removed wands of fireball - great example of a fun wand with a horrible implementation. Just was causing more problems than it was worth though 
15:38 <amateurhour> what
15:38 <amateurhour> no wands of fireball??????/
15:38 <hackemslashem> :(
15:39 <hackemslashem> They broke stuff, didn't play nicely with other spells
15:39 <amateurhour> but aren't they just the advanced fireball spells in wand form?
15:39 <qt> that's pretty strange behavior, after thinking about it some more I honestly think this makes the most sense https://termbin.com/2jtv
15:39 <hackemslashem> Hey, if you can implement them in an elegant way - I'll put'em back!
15:39 <hackemslashem> "basic" fireball in wand form
15:40 <hackemslashem> It's hard coded so you have to jump through hoops to make buzz recognize it as a spell though. Real PITA
15:41 <amateurhour> hmm, feels like it should just do exactly what the spell does
15:42 <Umbire> You've always been able to grease potions, just no real reason except habits from wishing up ig
15:43 <Umbire> Also yeah it does do that amateurhour, just a "basic" level fireball
15:43 <K2> heh wands of fireball
15:43 <Umbire> can't speak to the code situation though
15:44 <K2> grunthacks <projectiles> of detonation (oprop) were fun to a certain extent too
15:44 <K2> but it got stupid real quick
15:46 <hackemslashem> to be fair, I have bombs that accomplish a similar thing now so I don't think they will be missed much
15:46 <hackemslashem> But bombs .. also PITA
15:46 <Umbire> Oh, right. Just thought about firearms in an Evil-like environment
15:47 <Umbire> bet that'll be Fun™
15:48 <hackemslashem> Maybe? 
15:48 <amateurhour> it might just be fun without the trademark 
15:49 <amateurhour> guess we'll find out
15:59 <qt> amateurhour, hackemslashem: I might submit this https://termbin.com/41eh to vanilla devteam unless one of you guys wants to take charge of it
16:00 <hackemslashem> Sounds good, ship it!
16:00 <hackemslashem> There was also something last week I should send.. oh yea the expels thing
16:00 <amateurhour> I mentioned it to u cuz im too lazy
16:00 <amateurhour> I mean bcuz u would be interesting
16:00 <amateurhour> interested*
16:00 <amateurhour> man freudian slip
16:01 <hackemslashem> qt: There was also this one, https://github.com/elunna/hackem/issues/94
16:02 <hackemslashem> I chose the easy route (remove the message entirely), but the devteam could probably handle it better
16:02 <qt> huh
16:02 <qt> what is it, being expelled onto a levelporter?
16:02 <qt> or something like that?
16:02 <hackemslashem> yep
16:03 <hackemslashem> Broooaaaa
16:23 <qt> https://github.com/NetHack/NetHack/pull/936
16:23 <qt> here is the acid thing
16:24 <qt> idk what the right solution is to the expel->levelport scenario
16:24 <amateurhour> thank u qt
16:41 <Hecubus> [hdf-us] [evil] Nightsorrow (Sam Hum Mal Law) had Snickersnee bestowed upon him by Amaterasu Omikami, on T:12731
16:42 <hackemslashem> woot - turns out adding the prob field back to rings was as simple as adding the prob field back 
16:44 <Umbire> lol
17:09 <aosdict> do watch out for the code that tries to reset the probs for all RING_CLASS objects though
17:09 <aosdict> it's in o_init.c somewhere and 3.7 has got rid of it but I don't know if evil had also got rid of it
17:13 <hackemslashem> Not seeing anything like that thankfully
17:21 <qt> hackemslashem: I think the expels use-after-free thing is actually not that hard to fix, you can just move the message to before the spoteffects call
17:21 <qt> though I guess you said you just deleted it which works too
17:22 -!- Umbire has quit [Remote host closed the connection]
17:22 -!- Umbire has joined #evilhack
17:24 <Hecubus> [hdf-us] [evil] bouquet (Sam Gia Fem Law) killed the Goblin King, on T:5276
17:31 <qt> oh
17:31 <qt> never mind it still needs more than that
17:31 <qt> hmm
17:32 <Hecubus> [hdf-us] [evil] bouquet (Sam Gia Fem Law), 5644 points, T:6390, killed by a mumak
17:37 <qt> nvm this is different
17:45 <qt> hackemslashem: I am confused about how your issue happened actually
17:46 <hackemslashem> It was just a normal day, letting the fuzzer rip and then all of a sudden - 
17:46 <hackemslashem> Broooaaa!
17:46 <qt> it seems like it needs really specific circumstances
17:46 <qt> to reproduce
17:47 <qt> because normally the goto is deferred until the end of the turn
17:47 <qt> unless you are expelled on your own turn, not the monster's turn
17:47 <hackemslashem> I didn't even try to reproduce that, that's like, insane
17:47 <qt> i'm trying because I don't want to submit a patch to vanilla unless I can confirm it actually happens in vanilla
17:48 <hackemslashem> I think you need an amulet of lifesaving, so you die while engulfed, revive onto a levteleport trap, and are swooshed away
17:48 <hackemslashem> But maybe the lifesaving part isn't necessary...
17:50 <qt> there we go
17:50 <qt> I got it
17:50 <qt> it's really tough to get
17:51 <hackemslashem> that is nuts
17:51 <hackemslashem> What were you engulfed by?
17:51 <qt> you have to (a) die from a deadly timeout like sickness, (b) while engulfed, (c) on top of a level teleporter [or similar, maybe], (d) and there must be no open adjacent squares for the engulfer to go to (i.e. you're surrounded by other kinds of monsters)
17:51 <amateurhour> epic
17:51 <qt> now i will do the same thing again with my patch to see if it's fixed
17:52 <amateurhour> make sure to describe it in the PR as though you stumbled into that exact scenario by accident or something
17:52 <qt> patch does fix it, hooray
17:52 <amateurhour> \o/
17:52 <amateurhour> nice one qt
17:52 <hackemslashem> How did you figure out the timeout part?? 
17:52 <qt> it's in your backtrace
17:53 <qt> that the death was due to timeout
17:53 <hackemslashem> in end.c?  ohhh ok
17:53 <hackemslashem> done_timeout lol I see it
17:53 <qt> and I knew the only way it'd happen is if you die on your own turn, not the monsters' turn
17:53 <qt> so i was on the lookout for something like that
17:59 <hackemslashem> excellent work qt!
18:01 <qt> and as usual for these things that take forever to figure out, it's a one line change lol
18:03 <hackemslashem> What more could you ask for!
18:08 -!- mobileuser has quit [Quit: Connection closed]
18:13 <aosdict> not always, sometimes it's a "hmm this whole system would have to be redesigned and refactored"
18:40 -!- amateurhour has quit [Quit: leaving]
18:50 <K2> nice qt
18:50 <K2> you're on a roll
18:58 <qt> chopped cheese on a roll
19:00 <aosdict> I was very disappointed the day I learned "chopped cheese" was a meat sandwich
19:03 <K2> ooof, did you all see this one? mobileuser just posted this an hour ago (splicehack) - https://github.com/NullCGT/SpliceHack/issues/252
19:09 <K2> :(
19:19 <Hecubus> [hdf-us] [evil] Loggers (Mon Hum Mal Cha), 500 points, T:888, killed by trying to drink molten lava
19:27 <Hecubus> [hdf-us] [evil] Loggers (Mon Hum Mal Cha) murdered Soup Ears, his faithful kitten, on T:1548
19:34 <Hecubus> [hdf-us] [evil] Loggers (Mon Hum Mal Cha), 1392 points, T:3153, killed by the Goblin King
19:41 <Hecubus> [hdf-us] [evil] Loggers (Mon Hum Mal Cha) killed the Goblin King, on T:991
19:47 -!- dbanethacker has quit [Quit: Client closed]
19:56 <Hecubus> [hdf-us] [evil] Loggers (Mon Hum Mal Cha) made his first wish - "blessed fireproof +2 speed boots", on T:2820
20:06 <Hecubus> [hdf-us] [evil] Loggers (Mon Hum Mal Cha) killed the Rat King, on T:3526
20:11 <Umbire> K2: He was talking about it in the bridge channels earlier, sucks shit
20:38 -!- elenmirie has quit [Quit: Going offline, see ya! (www.adiirc.com)]
20:39 <Hecubus> [hdf-us] [evil] Loggers (Mon Hum Mal Cha) tasted meat for the first time, by eating a tripe ration, on T:7034
20:54 -!- hackemslashem has quit [Ping timeout: 252 seconds]
21:12 <Hecubus> [hdf-us] [evil] Loggers (Mon Hum Fem Cha), 44551 points, T:10273, petrified by a cockatrice
21:13 -!- rebatela has quit [Read error: Connection reset by peer]
21:13 -!- j_ has joined #evilhack
21:13 -!- j_ has quit [Client Quit]
21:13 -!- rebatela has joined #evilhack
22:14 <Hecubus> [hdf-us] [evil] lgxia (Kni Hum Mal Law) completed Sokoban, acquiring a silver amulet of magic resistance, on T:39191
22:24 <Hecubus> [hdf-us] [evil] bouquet (Sam Gia Fem Law) killed the Goblin King, on T:3489
22:25 <Hecubus> [hdf-us] [evil] bouquet (Sam Gia Fem Law) performed her first genocide (gelatinous cubes), on T:3536
22:32 <Hecubus> [hdf-us] [evil] bouquet (Sam Gia Fem Law) eschewed atheism, by dropping 53 arrows on an altar, on T:4361