00:05 you got this 00:06 *fixed it* 00:06 (price weirdness with racial shop keepers) 00:14 Yay? 00:15 (probably good in general but I could never really grok the details of what made it tick) 00:16 [EvilHack] k21971 pushed 1 commit to master [+0/-0/±2] https://git.io/J0Pwm 00:16 [EvilHack] k21971 ff8b0b2 - Fix: price abuse with non-human shopkeepers, player matching race. 00:30 !who 00:30 K2: [hdf-us] No current players :: [hdf-eu] No current players :: [hdf-au] Arahael [evil] 00:31 heya arahael 00:32 Hey. :) 00:32 mind saving real quick? i have a patch ready to go will only take a sec 00:32 Oh hol up 00:32 I just restarted my game, kept leaving it idle 00:32 Saved now though 00:32 Umbire you're fine already patched us 00:33 o 00:33 BLLER 00:33 Baller* 00:33 K2: Done. 00:33 and done 00:33 thanks you can resume 00:33 Too easy. :) 00:34 :P 01:08 *sigh*. 01:08 -!- jonadab has quit [Ping timeout: 268 seconds] 01:09 Found a "magical" grey stone... moved everything off it so that I could kick it, positioned myself just so... Then just picked the damn thing up! 01:10 Uh? 01:10 -!- jonadab has joined #evilhack 01:11 K2: I was just able to drop it...? I didn't identify it, but it was cursed... And 500aum... 01:11 I nearly wasted a scroll of remove curse on it! But shouldn't it have been a loadstone, and shouldn't I have been unable to drop it? 01:20 [hdf-au] [evil] Arahael (Wiz Ith Fem Cha), 3372 points, T:2933, killed by a gray unicorn 01:20 Weird game. 02:00 -!- elenmirie has joined #evilhack 02:04 -!- mobileuser has joined #evilhack 02:12 [hdf-us] [evil] Umbire (Pri Gia Fem Cha), 3346 points, T:5176, killed by an ape 02:50 -!- mobileuser has quit [Quit: Connection closed] 02:57 [hdf-us] [evil] tinklebear (Kni Hum Mal Cha), 6940 points, T:6681, killed by a hallucinogen-distorted hill orc 03:00 -!- mobileuser has joined #evilhack 03:02 -!- amateurhour has joined #evilhack 03:14 [hdf-eu] [evil] lacca (Inf Ith Fem Una), 1898 points, T:1976, killed by a mountain dwarf 03:24 [hdf-us] [evil] Umbire (Pri Gia Mal Cha), 1582 points, T:2270, quit 03:49 [hdf-eu] [evil] lacca (Inf Ith Fem Una), 2676 points, T:2110, poisoned by a bone orcish arrow 04:03 -!- elenmirie has quit [Quit: Going offline, see ya! (www.adiirc.com)] 04:05 -!- elenmirie has joined #evilhack 04:07 -!- elenmirie has quit [Remote host closed the connection] 04:26 [hdf-eu] [evil] NetSysFire (Inf Ith Fem Una), 1547 points, T:2332, killed by a giant mosquito 04:32 [hdf-us] [evil] Umbire (Pri Gia Fem Law), 2464 points, T:3989, killed by a homunculus, while sleeping 04:32 -!- lacca[m] has quit [Quit: Bridge terminating on SIGTERM] 04:35 -!- lacca[m] has joined #evilhack 05:03 -!- Umbire has quit [Quit: Umbire zaps a wand of digging!] 05:33 [hdf-us] [evil] DeathDealer (Ran Gno Mal Neu) had Mjollnir bestowed upon him by Venus, on T:42820 05:34 -!- Umbire has joined #evilhack 05:51 -!- Umbire is now known as Guest4339 05:52 -!- Umbire has joined #evilhack 05:55 -!- Guest4339 has quit [Ping timeout: 240 seconds] 06:23 -!- Umbire is now known as Guest3750 06:23 -!- Umbire has joined #evilhack 06:26 -!- Guest3750 has quit [Ping timeout: 240 seconds] 06:31 [hdf-us] [evil] Umbire (Pri Gia Mal Law) rejected atheism with a prayer, on T:4610 06:45 [hdf-eu] [evil] NetSysFire (Inf Ith Fem Una), 653 points, T:1656, zombified by a diseased hobbit corpse, while helpless 06:46 [hdf-eu] [evil] lacca (Inf Ith Fem Una) changed form for the first time by mimicking a pile of gold, on T:3346 06:54 K2: I'm not sure if the shk exploit is possible with humans, as they don't give any discounts to their own race 06:55 also that's not the fix I expected D: 06:55 now no discounts for same race shk??? 06:56 the fix I recommended was not call get_cost in set_cost, because that opens up a whole bunch of weirdness where cha affects sell price 06:56 it's not a bug anymore :) 07:09 aosdict there's more to do 07:09 but what i did got rid of the $$$ exploit 07:09 i was thinking about it this morning before i climbed out of bed hah 07:10 and no the exploit didnt affect human 07:22 [hdf-eu] [evil] lacca (Inf Ith Fem Una), 13222 points, T:5863, killed by a warg 07:27 K2 and his wife: https://i.imgflip.com/5k3cn8.jpg 07:27 lol 07:30 Expect the wiki'll be updated accordingly before long? 07:32 ^ volunteer! :b 07:48 Umbire there's more to do 07:48 i wouldnt update anything yet 07:48 As in when you're done, ofc I'm not gonna update anything yet 07:49 i think right now the only same race discount is with orcs 07:49 i need to make sure that cant be exploited either. i dont think so 07:51 as long as you call get_cost in set_cost there will be problems 07:51 just enforce sell cost never > 50% of base, buy cost never < 50% of base 07:52 all problems solved, you can have same race discounts 07:52 yeah 07:53 but, more tests 07:53 MOAR 07:58 $$$ exploit still exists for orc same race shpkeeper 07:58 bleh 07:58 alright aosdict throw me a bone 07:59 wait no lemme figure it out 08:03 remove the get_cost term from 'final quick check' and replace it with half base cost 08:04 then make sure that get_cost also has a term preventing an item from being bought for less than half base cost 08:09 [hdf-us] [evil] Umbire (Pri Gia Mal Law) killed the Oracle, on T:8997 08:10 hrm, this isnt my strong suit 08:10 will try 08:16 i dont how to express half base cost it seems 08:17 the simplest way discarding obj material adjustments is objects[obj->otyp].oc_cost / 2 08:18 thx 08:20 hmm now the shpkeeper isnt interested in anything i sell 08:21 i'm doing this wrong bleh 08:34 [hdf-eu] [evil] lacca (Inf Ith Fem Una), 1902 points, T:1153, killed by a bolt of cold 08:35 yeah i dont get this, cant seem to wrap my head around it. the changes i am making either 1) dont change anything or 2) screw things up worse than they are 08:35 hah 08:49 [hdf-us] [evil] Umbire (Pri Gia Mal Law) destroyed the invisible lacca's ghost, the former Heretic, on T:12946 09:01 yup, i'm going to need help with this :/ 09:01 shit 09:19 -!- Umbire has quit [Ping timeout: 240 seconds] 10:07 hmm something else is wrong i think 10:08 think i've noticed this before but now i remember 10:08 shopkeepers that like you and give you a price break on buying things, selling the same object with higher cha, you get less $$$ than selling with lower cha 10:09 its reversed 10:09 ^ that's the problem 10:44 if i recall, sporkhack has this same issue, just expressed differently 10:45 did you port it from sporkhack 10:45 ? 10:45 initially 10:45 but its changed a lot since 10:46 aosdict said something about differences between 3.4.3 and 3.6 in the calculation of prices 10:46 i dont do math all day everyday like some other people here. its taking me awhile to grok this 10:51 I can tell you that "sign error" is one of the most encountered error for people who do math on a daily bases 10:52 heh 10:52 it also often doesn't get caught unless it's a really obvious one. like "if physics worked this way, Newton would have hit the apple and not the other way round". 10:53 [hdf-eu] [evil] NetSysFire (Inf Ith Mal Una) rejected atheism with a prayer, on T:3821 10:55 [hdf-eu] [evil] NetSysFire (Inf Ith Mal Una), 3125 points, T:4504, killed by a champion of Hermes 11:00 -!- qt has joined #evilhack 11:31 K2: here's the additional barding stuff I was doing yesterday if you want to check it out https://termbin.com/t661 11:31 cool 11:34 hah nice, repair armor spell can target barding 11:34 good call 11:45 wanna do that as a PR? 11:49 sure 11:50 thanks 12:22 [EvilHack] entrez opened pull request #66: Make barding more like armor - https://git.io/J0dRd 12:30 [EvilHack] k21971 pushed 2 commits to master [+0/-0/±18] https://git.io/J0dge 12:30 [EvilHack] entrez 3b3da8b - Make barding more like armor 12:30 [EvilHack] k21971 e903263 - Merge pull request #66 from entrez/barding-stuff 12:31 nice 12:43 this is really cool qt. this should help keep steeds alive a bit longer 12:44 +5 mithril barding is an extra 10 ac 12:44 wonder if that'll be too OP hah 12:47 i hope so 12:47 my goal is to counteract all your evil intentions by introducing things that are overpowered in favor of the player 12:47 i'm a man of the people in that way 12:48 my next PR will add guaranteed dlvl1 WOW for all 12:48 blaspheme 12:49 i might drop base AC by 2 since you can now enchant it 12:49 dunno 12:50 prob leave it alone for now 12:50 maybe you should drop the weird special bonus for mithril instead ;) 12:50 that was my real ulterior motive 12:50 but... it's mithril 15:00 -!- Not-da3c has quit [*.net *.split] 15:08 [hdf-eu] [evil] lacca (Inf Ith Fem Una), 7666 points, T:3743, killed by a gnomish watchman 15:10 [hdf-us] [evil] bouquet (Wiz Gno Fem Cha) killed the Abominable Snowman, on T:72438 15:14 my pet basilisk isn't turning stonable monsters to stone. Is their stoning attack no good as a pet? 15:14 hmm 15:15 lemme see whats up 15:17 is it canceled? 15:17 I didn't cancel it. 15:17 hmm no its not working 15:17 tame cockatrice i have in wizmode touched a hill orc, nada 15:17 I know they can stone me because I narrowly avoided turning to a statue earlier in the game 15:17 and they can stone each other 15:17 err i mean mon can stone mon when not tame 15:18 huh 15:19 hmm no 15:20 wonder what i did 15:20 i'll fix it 15:20 hmm 15:21 i think i see what happened 15:22 dont tell me (yet) 15:22 did a fall through case not get reached? 15:22 i dont want you to charge me NFT's lol 15:26 heh i think i see it 15:29 yup 15:37 how did that happen 15:37 i'll show ya 15:37 this was missing under AD_STON in mhitm - https://termbin.com/ge7w 15:38 there were conditions for medusa's gaze as well as beholder's gaze 15:38 but no touchy 15:38 yes but I mean, how did it happen that the normal stuff was removed 15:38 i need to tweak that a bit to cut down on is slowing down spam 15:39 oh, because i made stoning be slow stoning 15:39 at least from an attack by 15:39 you or touching them is still instant 15:39 means this bug has existed for *awhile* 15:40 good catch bouquet 15:40 easy fix 15:41 I do what I can. 15:46 awww booo 15:46 Not left the channel 15:47 fix will go live later, the last PR that qt did, I shouldn't patch until people aren't playing 15:57 now i need to figure out the racial shopkeeper pricing crap 15:58 i should setup some debug plines so I can see exactly which denominator/numerator is being chosen 15:58 speaking of which, I like how shopkeepers are so racist that they will insult you to your face, but still respectful enough that they use the correct Japanese term to greet you 15:58 in the same sentence 16:00 :) 16:00 the 'fix' I pushed yesterday was only partial 16:00 as in, very minor hardly at all partial fix 16:01 there's some weird shit going on with racial shopkeeper prices 16:01 shopkeepers that like you and give you a price break on buying things, selling the same object with higher cha, you get less $$$ than selling with lower cha 16:02 brb 16:03 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) wished for "blessed +2 dragonhide helm of brilliance", on T:60776 16:07 interesting, some zombies in Katharine's chamber bit the dogs and made them peaceful before I beat icy 16:08 [hdf-us] [evil] bouquet (Wiz Gno Fem Cha) defeated Kathryn the Ice Queen, on T:73153 16:08 hah 16:08 another edge case bug 16:08 they should have bobble hats 16:08 you're on a roll 16:10 k2 that makes sense -- if a shopkeeper likes you, you get lower selling price and higher buying price, and high CHA reduces the selling price even more 16:10 you should have seen me in splicehack. More corners than a thing with lots of corners! 16:10 qt no I mean when you sell an object *to* the shopkeeper 16:10 yeah 16:10 that's what I mean too 16:10 is acid the only way to get through the bars in Katharine's chamber? 16:11 i guess i'm just using them backwards 16:11 if they like you, you should get more $$$ for it 16:11 when i say buying price i mean 'selling to' the shopkeeper 16:11 ok 16:11 at least acid is helpfully provided bouquet 16:11 bouquet yes 16:12 provided where? None of the crystal chests had it 16:12 huh? 16:12 that's weird 16:12 yeah they would have 16:12 its hard coded 16:12 [hdf-us] [evil] bouquet (Wiz Gno Fem Cha) genocided master mind flayers, on T:73204 16:13 high CHA drives the 'buying from' price so low that it ends up lower than the 'selling to' price, so the selling price gets modified because of that 'if (tmp > get_cost...' part 16:13 qt aside from that 16:13 or maybe thats a factor 16:13 I'll double check... 16:14 easiest way to test this: roll an orcish infidel, wish up a blessed of excellence and a cursed of excellence 16:14 as you switch back/forth between wielding those weapons, cha will go from 25 to 6 and back 16:14 ah. There was another glyph over it. 16:14 -!- mobileuser has quit [Quit: Connection closed] 16:14 then go to minetown and reload the map until you get a shop with an orcish shopkeeper 16:15 offer to sell an object to said shopkeeper, first with 25 cha then with 6 cha 16:15 you'll be offered more $$$ when your charisma is 6 16:15 (same object) 16:16 it should be other way around 16:16 ah, the stoning patch is already working 16:16 i havent patched the servers yet 16:17 if a monster bare hand touches your pet basilisk or cockatrice, they'll still turn to stone 16:17 that bit wasnt broken 16:17 the broken part was them touching another monster 16:17 headed home, back soon 16:18 K2: what's happening is that the selling price for a food ration e.g. is 34 zorkmids. CHA doesn't factor in to selling price at all 16:18 when your CHA is low the buying price is 45 or something, so the selling price is lower and it stays at 34 zorkmids 16:19 when your CHA is high the buying price is 15 zorkmids, so the selling price gets forced lower than the buying price 16:22 wild. Stuff was suddenly getting stoned everywhere. 16:22 whevs 16:29 -!- mobileuser has joined #evilhack 16:40 qt: are you using buying price to mean set_cost and selling price to mean get_cost 16:40 cause that's backwards from standard terminology 16:41 [hdf-us] [evil] tinklebear (Kni Elf Mal Cha) murdered Vita Fidelia, his faithful lesser nightmare, on T:2130 16:42 anyway "selling price forced lower than buying price" means that you haven't successfully removed all instances of those two functions calling each other 16:42 [hdf-us] [evil] tinklebear (Kni Elf Mal Cha), 2108 points, T:2131, quit 16:43 aosdict: i have used them both ways in this conversation lol 16:43 i am deeply confused about it myself 16:44 but yes set_cost still calls get_cost, which is the source of the issue 16:44 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) wished for "uncursed magic marker", on T:61057 16:47 whew 16:47 glad i'm not the only one that's confused 16:54 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) wished for "blessed amulet of life saving", on T:61068 17:15 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) murdered his faithful red dragon, on T:61312 17:23 [hdf-us] [evil] Jason (Kni Hum Mal Law), 404 points, T:1869, killed by a steel crossbow bolt 17:27 -!- amateurhour has quit [Quit: zzz] 17:50 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) destroyed Charon, on T:62274 17:50 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) killed Cerberus, on T:62288 17:52 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) entered Gehennom, on T:62329 18:01 -!- mobileuser has quit [Quit: Connection closed] 18:24 -!- rebatela has joined #evilhack 18:38 -!- Umbire has joined #evilhack 18:45 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) killed Baphomet, on T:63155 19:01 [hdf-us] [evil] DeathDealer (Ran Gno Mal Neu) killed Scorpius, on T:49391 19:01 [hdf-us] [evil] DeathDealer (Ran Gno Mal Neu) acquired the Bell of Opening, on T:49395 19:04 [hdf-us] [evil] sluggoman (Wiz Hum Mal Neu) killed Yeenoghu, on T:63712 19:08 -!- qt has quit [Quit: later, losers] 19:35 [hdf-us] [evil] DeathDealer (Ran Gno Mal Neu) killed the invisible Orion, on T:50391 21:21 > Suddenly you cannot see it. 21:21 Wonder what that was! 22:33 [hdf-us] [evil] Umbire (Pri Gia Mal Law) changed form for the first time by mimicking a pile of gold, on T:17585 22:37 -!- Not has joined #evilhack 22:37 [EvilHack] k21971 pushed 1 commit to master [+0/-0/±2] https://git.io/J0byO 22:37 [EvilHack] k21971 631b185 - Fix: no really, fix price abuse with non-human shopkeepers, player matching race. 22:40 !who 22:40 K2: [hdf-eu] No current players :: [hdf-us] Umbire [evil] sluggoman [evil] :: [hdf-au] No current players 22:42 Already saved. 22:44 thanks, i wasnt gonna ask though 22:44 i think sluggo is still playing 22:44 !who 22:44 K2: [hdf-eu] No current players :: [hdf-us] No current players :: [hdf-au] No current players 22:44 ooh 22:44 there we go, all patched 22:46 Baller. 23:08 [hdf-au] [evil] Arahael (Wiz Ith Fem Cha), 3633 points, T:3420, killed by a bolt of cold 23:14 Such a good game! Two magic lamps, random steel GoP, etc, but the next level must've been a bones level and a troll with a wand of cold was right by the stairs. 23:16 oof 23:20 Unfortunate. 23:20 I need to go back for that Orctown bones, on that note. 23:21 I still need complete poison res first, though, also somewhat better AC. 23:21 Granted the mastodon can compensate for that, but I prefer she not have to. 23:28 I've somehow lost my pet in this new game. 23:30 [hdf-au] [evil] Arahael (Wiz Ith Fem Cha) destroyed the invisible Jason's ghost, the former Esquire, on T:1977 23:44 [hdf-au] [evil] Arahael (Wiz Ith Fem Cha), 2323 points, T:2741, killed by a mountain dwarf